Re: [PATCH v3] The Yosemite V3.5 is a facebook multi-node server platform that host four OCP server. The BMC in the Yosemite V3.5 platform based on AST2600 SoC.

From: Arnd Bergmann
Date: Thu Jul 07 2022 - 09:34:15 EST


On Thu, Jul 7, 2022 at 3:20 PM Logananth Sundararaj
<logananth13.hcl@xxxxxxxxx> wrote:
>
> This patch adds linux device tree entry related to
> Yosemite V3.5 specific devices connected to BMC SoC.
>
> Signed-off-by: Logananth Sundararaj <logananth_s@xxxxxxx>


Something went wrong with the patch description, it looks like you dropped
the subject and sent the first paragraph as the subject instead.

> +/ {
> + model = "Facebook fby35";
> + compatible = "facebook,fby35", "aspeed,ast2600";
> +
> + aliases {
> + serial4 = &uart5;
> + };

Why not start at serial0 here?

> + chosen {
> + stdout-path = &uart5;
> + bootargs = "console=ttyS4,57600n8 root=/dev/ram rw vmalloc=384M";
> + };

The bootargs should really come from the boot loader.

Why do you need the vmalloc=384M? That seems excessive.

> +
> + memory@80000000 {
> + device_type = "memory";
> + reg = <0x80000000 0x80000000>;
> + };

The memory location and size is usually also set by the boot loader

Arnd