Re: [PATCH] arm64: dts: qcom: sc7280: Move wcd specific pin conf to common file

From: Srinivasa Rao Mandadapu
Date: Thu Jul 07 2022 - 08:28:34 EST



On 7/7/2022 2:13 AM, Doug Anderson wrote:
Thanks for your time Doug!!!
Hi,

On Wed, Jul 6, 2022 at 3:17 AM Srinivasa Rao Mandadapu
<quic_srivasam@xxxxxxxxxxx> wrote:
+/* PINCTRL - BOARD-SPECIFIC */
It's not really "board specific" since this is actually a file that's
included by multiple boards.
Okay. Will update accordingly.

Maybe just use the header "PINCTRL" for now. Everything here is just
adding pull/drive strength/slew-rate info to existing pinctrl
settings. If we ever have more than that and want to separate into
different sections we can always adjust later.


+/*
+ * Methodology for gpio-line-names:
+ * - If a pin goes to CRD board and is named it gets that name.
+ * - If a pin goes to CRD board and is not named, it gets no name.
+ * - If a pin is totally internal to Qcard then it gets Qcard name.
+ * - If a pin is not hooked up on Qcard, it gets no name.
+ */
This file doesn't include "gpio-line-names" so you don't need to
include documentation about it.
Okay. Will remove it.

-Doug