RE: [PATCH 4/4] tty: n_gsm: fix missing corner cases in gsmld_poll()

From: Starke, Daniel
Date: Thu Jul 07 2022 - 03:01:59 EST


> > @@ -3051,14 +3051,20 @@ static __poll_t gsmld_poll(struct tty_struct *tty, struct file *file,
> > __poll_t mask = 0;
> > struct gsm_mux *gsm = tty->disc_data;
> >
> > + if (!gsm)
> > + return EPOLLHUP;
>
> Hmm, how can this happen? It's a tty bug if it calls ld ops after NULLing
> disc_data.

I can remove this check if it is redundant. Should I?

Best regards,
Daniel Starke