Re: [PATCH] sched/fair: fix case with reduced capacity CPU

[Vincent Guittot]

On Wed, 6 Jul 2022 at 01:50, David Chen <david.chen@xxxxxxxxxxx> wrote:
>
>
>
> > -----Original Message-----
> > From: Zhang Qiao <zhangqiao22@xxxxxxxxxx>
> > Sent: Tuesday, July 5, 2022 1:23 AM
> > To: Vincent Guittot <vincent.guittot@xxxxxxxxxx>
> > Cc: mingo@xxxxxxxxxx; peterz@xxxxxxxxxxxxx; juri.lelli@xxxxxxxxxx; dietmar.eggemann@xxxxxxx; rostedt@xxxxxxxxxxx;
> > bsegall@xxxxxxxxxx; mgorman@xxxxxxx; bristot@xxxxxxxxxx; vschneid@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; David Chen
> > <david.chen@xxxxxxxxxxx>
> > Subject: Re: [PATCH] sched/fair: fix case with reduced capacity CPU
> >
> >
> >
> > 在 2022/7/2 12:52, Vincent Guittot 写道:
> > > The capacity of the CPU available for CFS tasks can be reduced because of
> > > other activities running on the latter. In such case, it's worth trying to
> > > move CFS tasks on a CPU with more available capacity.
> > >
> > > The rework of the load balance has filterd the case when the CPU is
> > > classified to be fully busy but its capacity is reduced.
> > >
> > > Check if CPU's capacity is reduced while gathering load balance statistics
> > > and classify it group_misfit_task instead of group_fully_busy so we can
> > > try to move the load on another CPU.
> > >
> > > Reported-by: David Chen <david.chen@xxxxxxxxxxx>
> > > Reported-by: Zhang Qiao <zhangqiao22@xxxxxxxxxx>
> > > Signed-off-by: Vincent Guittot <vincent.guittot@xxxxxxxxxx>
> > > ---
> > >
> > > David, Zhang,
> > >
> > > I haven't put your tested-by because I have reworked and cleaned the patch to
> > > cover more cases.
> > >
> > > Could you run some tests with this version ?
> >
> > I tested with this version, it is ok.
> >
> > Tested-by: Zhang Qiao <zhangqiao22@xxxxxxxxxx>
> >
> > Thanks
>
> This version works fine with me.
> Tested-by: David Chen <david.chen@xxxxxxxxxxx>

Thanks

>
> Thanks
>

> > >