Re: [PATCH v12 3/7] arm64: dts: allwinner: Add Allwinner H616 .dtsi file

From: Samuel Holland
Date: Thu Jul 07 2022 - 02:36:41 EST


Hi Andre,

On 7/5/22 5:42 AM, Andre Przywara wrote:
> On Mon, 4 Jul 2022 20:16:50 -0500
> Samuel Holland <samuel@xxxxxxxxxxxx> wrote:
>>> + i2c0: i2c@5002000 {
>>> + compatible = "allwinner,sun50i-h616-i2c",
>>> + "allwinner,sun6i-a31-i2c";
>>
>> Future note: this will be affected by [1] which adds a fallback compatible for
>> variants with offload support. That way we don't have to support them all
>> individually in the driver if/when we implement that.
>>
>> [1]: https://lore.kernel.org/lkml/20220702052544.31443-1-samuel@xxxxxxxxxxxx/
>
> I saw (and liked) that. Shall I insert the compatible string already? Or
> is it too early for that, because dtbs_checks would fail without the
> amended binding in the tree?

The updated binding is in linux-next, so please add the new compatible.

Regards,
Samuel