Re: [PATCH] media: docs: Remove extraneous \endgroup from P010 table

From: Akira Yokosawa
Date: Wed Jul 06 2022 - 21:02:01 EST


On Wed, 29 Jun 2022 22:01:17 +0900, Akira Yokosawa wrote:
> The \endgroup command at the bottom of a table added in commit
> 5374d8fb75f3 ("media: Add P010 video format") doesn't have a
> corresponding \begingroup command preceding it.
>
> This imbalance causes an build error in "make pdfdocs".
>
> Fix the issue by removing it.
>
> Signed-off-by: Akira Yokosawa <akiyks@xxxxxxxxx>
> Fixes: 5374d8fb75f3 ("media: Add P010 video format")
> Cc: Benjamin Gaignard <benjamin.gaignard@xxxxxxxxxxxxx>
> Cc: Nicolas Dufresne <nicolas.dufresne@xxxxxxxxxxxxx>
> Cc: Hans Verkuil <hverkuil-cisco@xxxxxxxxx>
> Cc: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>
> ---
> Hi Mauro,
>
> In my (bi-weekly) test of "make pdfdocs" against next-20220629,
> I encountered a build error of userspace-api.tex.
>
> This patch fixes it.
>
> This is relative to 'master' of git://linuxtv.org/media_tree.git
> as merged by Stephen.
Gentle ping, Mauro.

I assume the offending patch is destined for the next merge window.
If it lands as is, "make pdfdocs" will end up in:

> Latexmk: Errors, so I did not complete making targets

> Collected error summary (may duplicate other messages):

> xelatex: Command for 'xelatex' gave return code 1

> Refer to 'userspace-api.log' for details

> Latexmk: Use the -f option to force complete processing,

> unless error was exceeding maximum runs, or warnings treated as errors.

> make[2]: *** [Makefile:29: userspace-api.pdf] Error 12

> make[1]: *** [Documentation/Makefile:115: pdfdocs] Error 2

> make: *** [Makefile:1686: pdfdocs] Error 2


Here is the relevant part from the middle of userspace-api.log:

> ! Extra \endgroup.
> l.27734 \endgroup
>
> Things are pretty mixed up, but I think the worst is over.

Or am I missing something?

Thanks, Akira

>
> Thanks, Akira
> --
> Documentation/userspace-api/media/v4l/pixfmt-yuv-planar.rst | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/Documentation/userspace-api/media/v4l/pixfmt-yuv-planar.rst b/Documentation/userspace-api/media/v4l/pixfmt-yuv-planar.rst
> index a900ff66911a..997ce2d094fc 100644
> --- a/Documentation/userspace-api/media/v4l/pixfmt-yuv-planar.rst
> +++ b/Documentation/userspace-api/media/v4l/pixfmt-yuv-planar.rst
> @@ -570,9 +570,6 @@ Data in the 10 high bits, zeros in the 6 low bits, arranged in little endian ord
> - Cb\ :sub:`11`
> - Cr\ :sub:`11`
>
> -.. raw:: latex
> -
> - \endgroup
>
> Fully Planar YUV Formats
> ========================
>
> base-commit: 945a9a8e448b65bec055d37eba58f711b39f66f0