RE: [EXT] RE: [PATCH v3 19/24] dmaengine: dw-edma: Use non-atomic io-64 methods

From: Yoshihiro Shimoda
Date: Wed Jul 06 2022 - 20:36:04 EST


Hi,

> From: Frank Li, Sent: Wednesday, July 6, 2022 11:29 PM
>
> > > From: Serge Semin, Sent: Friday, June 10, 2022 6:15 PM
<snip>
> >
> > Since both codes in #ifdef and #else are the same, we can just remove code
> > of the #else part.
> > But, what do you think?
> > -----
> > #ifdef CONFIG_64BIT
> > /* llp is not aligned on 64bit -> keep 32bit accesses */
> > SET_CH_32(dw, chan->dir, chan->id, llp.lsb,
> > lower_32_bits(chunk->ll_region.paddr));
> > SET_CH_32(dw, chan->dir, chan->id, llp.msb,
> > upper_32_bits(chunk->ll_region.paddr));
> > #else /* CONFIG_64BIT */
> > SET_CH_32(dw, chan->dir, chan->id, llp.lsb,
> > lower_32_bits(chunk->ll_region.paddr));
> > SET_CH_32(dw, chan->dir, chan->id, llp.msb,
> > upper_32_bits(chunk->ll_region.paddr));
> > #endif /* CONFIG_64BIT */
> > -----
> >
>
> Latest Linux-next code have removed CONFIG_64BIT.

Thank you for the information! I had looked the PCI repository only.
I confirmed the latest Linux-next (next-20220706 tag) code have removed the CONFIG_64BIT.

Best regards,
Yoshihiro Shimoda