Re: [PATCH 3/3] kunit: tool: refactoring printing logic into kunit_printer.py

From: Brendan Higgins
Date: Wed Jul 06 2022 - 15:17:01 EST


On Mon, May 16, 2022 at 3:48 PM Daniel Latypov <dlatypov@xxxxxxxxxx> wrote:
>
> Context:
> * kunit_kernel.py is importing kunit_parser.py just to use the
> print_with_timestamp() function
> * the parser is directly printing to stdout, which will become an issue
> if we ever try to run multiple kernels in parallel
>
> This patch introduces a kunit_printer.py file and migrates callers of
> kunit_parser.print_with_timestamp() to call
> kunit_printer.stdout.print_with_timestamp() instead.
>
> Future changes:
> If we want to support showing results for parallel runs, we could then
> create new Printer's that don't directly write to stdout and refactor
> the code to pass around these Printer objects.
>
> Signed-off-by: Daniel Latypov <dlatypov@xxxxxxxxxx>

Reviewed-by: Brendan Higgins <brendanhiggins@xxxxxxxxxx>