Re: [PATCH v6 1/2] highmem: Make __kunmap_{local,atomic}() take "const void *"

From: Andrew Morton
Date: Wed Jul 06 2022 - 15:07:19 EST


On Wed, 6 Jul 2022 13:15:19 +0200 "Fabio M. De Francesco" <fmdefrancesco@xxxxxxxxx> wrote:

> __kunmap_ {local,atomic}() currently take pointers to void. However, this
> is semantically incorrect, since these functions do not change the memory
> their arguments point to.
>
> Therefore, make this semantics explicit by modifying the
> __kunmap_{local,atomic}() prototypes to take pointers to const void.
>
> As a side effect, compilers will likely produce more efficient code.
>

Acked-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>

Please include this in the btrfs tree if/when [2/2] is added.