RE: [PATCH v5 1/4] spi: dw: Fix IP-core versions macro

From: Srikandan, Nandhini
Date: Wed Jul 06 2022 - 10:56:38 EST




> -----Original Message-----
> From: Mark Brown <broonie@xxxxxxxxxx>
> Sent: Wednesday, July 6, 2022 5:28 PM
> To: Srikandan, Nandhini <nandhini.srikandan@xxxxxxxxx>
> Cc: fancer.lancer@xxxxxxxxx; robh+dt@xxxxxxxxxx; linux-
> spi@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; mgross@xxxxxxxxxxxxxxx; Pan, Kris
> <kris.pan@xxxxxxxxx>; Demakkanavar, Kenchappa
> <kenchappa.demakkanavar@xxxxxxxxx>; Zhou, Furong
> <furong.zhou@xxxxxxxxx>; Sangannavar, Mallikarjunappa
> <mallikarjunappa.sangannavar@xxxxxxxxx>; Vaidya, Mahesh R
> <mahesh.r.vaidya@xxxxxxxxx>; A, Rashmi <rashmi.a@xxxxxxxxx>
> Subject: Re: [PATCH v5 1/4] spi: dw: Fix IP-core versions macro
>
> On Wed, Jul 06, 2022 at 12:20:36PM +0800, nandhini.srikandan@xxxxxxxxx
> wrote:
> > From: Nandhini Srikandan <nandhini.srikandan@xxxxxxxxx>
> >
> > Fixes: 2cc8d9227bbb ("spi: dw: Introduce Synopsys IP-core versions
> interface")
> > Signed-off-by: Nandhini Srikandan <nandhini.srikandan@xxxxxxxxx>
>
> What is the problem and how does this patch fix it?
The macro was introduced by Serge Semin in the patch set (2cc8d9227bbb) but it was unused.
It is used by one of the patches in the current patchset and without the fix it leads to compilation error. I had included this in v4 and Serge Semin had asked me to add the "Fixes: 2cc8d9227bbb" tag and keep it at the top of the series. So, I have kept it as first patch in this patchset series.

- Nandhini