Re: [PATCH] maple_tree: Fix use of node for global range in mas_wr_spanning_store()

From: Liam Howlett
Date: Wed Jul 06 2022 - 10:08:48 EST


* Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> [220705 22:55]:
> On Wed, 6 Jul 2022 02:05:37 +0000 Liam Howlett <liam.howlett@xxxxxxxxxx> wrote:
>
> > When writing a range with a NULL which expands to 0 - ULONG_MAX, don't
> > use a node to store this value. Instead, call mas_new_root() which will
> > set the tree pointer to NULL and free all the nodes.
> >
> > Fix a comment for the allocations in mas_wr_spanning_store().
> >
> > Add mas_node_count_gfp() and use it to clean up mas_preallocate().
> >
> > Clean up mas_preallocate() and ensure the ma_state is safe on return.
> >
> > Update maple_tree.h to set alloc = NULL.
>
> Cool.
>
> How are we looking now? Any known issues still being worked on?

Did you pick up "Subject: [PATCH] mm/mmap: Fix copy_vma() new_vma
check"? I sent that yesterday as well.

I think we are in good shape. There were two outstanding issues I had
and this patch plus the copy_vma() patch fixes both.