Re: [V3 4/7] remoteproc: qcom: pas: Check if coredump is enabled

From: Konrad Dybcio
Date: Wed Jul 06 2022 - 08:41:08 EST




On 5.07.2022 14:08, Sibi Sankar wrote:
> From: Siddharth Gupta <sidgup@xxxxxxxxxxxxxx>
>
> Client drivers need to check if coredump is enabled for the rproc before
> continuing with coredump generation. This change adds a check in the PAS
> driver.
>
> Fixes: 8ed8485c4f05 ("remoteproc: qcom: Add capability to collect minidumps")
> Signed-off-by: Siddharth Gupta <sidgup@xxxxxxxxxxxxxx>
> Signed-off-by: Sibi Sankar <quic_sibis@xxxxxxxxxxx>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxx>

Konrad
> drivers/remoteproc/qcom_q6v5_pas.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
> index 43dde151120f..d103101a5ea0 100644
> --- a/drivers/remoteproc/qcom_q6v5_pas.c
> +++ b/drivers/remoteproc/qcom_q6v5_pas.c
> @@ -92,6 +92,9 @@ static void adsp_minidump(struct rproc *rproc)
> {
> struct qcom_adsp *adsp = rproc->priv;
>
> + if (rproc->dump_conf == RPROC_COREDUMP_DISABLED)
> + return;
> +
> qcom_minidump(rproc, adsp->minidump_id);
> }
>