Re: [PATCH RESEND v5 1/5] iommu: Refactor iommu_group_store_type()

From: Will Deacon
Date: Wed Jul 06 2022 - 08:13:36 EST


On Wed, Jul 06, 2022 at 01:03:44PM +0100, John Garry wrote:
> On 06/07/2022 13:00, Will Deacon wrote:
> > On Mon, Apr 04, 2022 at 07:27:10PM +0800, John Garry wrote:
> > > Function iommu_group_store_type() supports changing the default domain
> > > of an IOMMU group.
> > >
> > > Many conditions need to be satisfied and steps taken for this action to be
> > > successful.
> > >
> > > Satisfying these conditions and steps will be required for setting other
> > > IOMMU group attributes, so factor into a common part and a part specific
> > > to update the IOMMU group attribute.
> > >
> > > No functional change intended.
> > >
> > > Some code comments are tidied up also.
> > >
> > > Signed-off-by: John Garry<john.garry@xxxxxxxxxx>
> > > ---
> > > drivers/iommu/iommu.c | 96 ++++++++++++++++++++++++++++---------------
> > > 1 file changed, 62 insertions(+), 34 deletions(-)
> > Acked-by: Will Deacon<will@xxxxxxxxxx>
> >
>
> Thanks, but currently I have no plans to progress this series, in favour of
> this https://lore.kernel.org/linux-iommu/1656590892-42307-1-git-send-email-john.garry@xxxxxxxxxx/T/#me0e806913050c95f6e6ba2c7f7d96d51ce191204

heh, then I'll stop reviewing it then :) Shame, I quite liked it so far!

Will