Re: [PATCH] ptrace: fix clearing of JOBCTL_TRACED in ptrace_unfreeze_traced()

From: Oleg Nesterov
Date: Wed Jul 06 2022 - 07:04:50 EST


On 07/06, Sven Schnelle wrote:
>
> --- a/kernel/ptrace.c
> +++ b/kernel/ptrace.c
> @@ -222,7 +222,7 @@ static void ptrace_unfreeze_traced(struct task_struct *task)
> if (lock_task_sighand(task, &flags)) {
> task->jobctl &= ~JOBCTL_PTRACE_FROZEN;
> if (__fatal_signal_pending(task)) {
> - task->jobctl &= ~TASK_TRACED;
> + task->jobctl &= ~JOBCTL_TRACED;

Heh. I have read this code many times, but I'm afraid I could read it
1000 times more and didn't notice the problem ;)

Thanks!

Oleg.