Re: [PATCH V3 02/11] dt-bindings: pci: tegra: Convert to json-schema

[Vidya Sagar]

On 7/6/2022 3:36 PM, Krzysztof Kozlowski wrote:
> External email: Use caution opening links or attachments
>
>
> On 06/07/2022 11:53, Vidya Sagar wrote:
> > > > +  nvidia,bpmp:
> > > > +    $ref: /schemas/types.yaml#/definitions/phandle-array
> > > > +    description: |
> > > > +      Must contain a pair of phandle to BPMP controller node followed by controller ID. Following
> > > > +      are the controller IDs for each controller:
> > > > +
> > > > +        0: C0
> > > > +        1: C1
> > > > +        2: C2
> > > > +        3: C3
> > > > +        4: C4
> > > > +        5: C5
> > > > +    items:
> > > > +      - items:
> > > > +          - minimum: 0
> > > > +            maximum: 0xffffffff
> > >
> > > That's already the limit. Just a description is fine.
> > >
> > > > +          - enum: [ 0, 1, 2, 3, 4, 5 ]
> > >
> > > maximum: 5
> >
> > Setting the maximum to '5' is resulting in the following error.
> >
> > pcie-ep@141a0000: nvidia,bpmp:0:0: 4294967295 is greater than the
> > maximum of 5
> >
> > Could you please help me understand why I'm seeing this error?
>
> Trim your replies.
>
> Why adding minimum:5 to the phandle? Rob said add a description. Nothing
> about minimum.

I'm sorry I didn't understand the review comment clearly.
There is one description added above already. Are you (and Rob) saying 
that one more description is needed?

Thanks,
Vidya Sagar


> Best regards,
> Krzysztof