Re: [PATCH 1/2] [V1,1/2] arm64: dts: qcom: Add LTE SKUs for sc7280-villager family

From: Krzysztof Kozlowski
Date: Wed Jul 06 2022 - 06:05:29 EST


On 06/07/2022 11:36, Jimmy Chen wrote:
> To keep the consistency of the format for Chromebook items,
> we basically add these items based on the rules discussed in the previous patch series here
> https://lore.kernel.org/all/20220520143502.v4.1.I71e42c6174f1cec17da3024c9f73ba373263b9b6@changeid/.
>
> We are little configured with “one entry - one enum “. Do you mean something like below example?
> We suggest keep items separated as it is more readable.
>
> - description: Google Villager
> items:
> - const: google,villager-rev0
> - const: google,villager
> - const: google,villager-rev0-sku0
> - const: google,villager-sku0
> - const: qcom,sc7280
>

Is this a reply to something we discussed? There is no quote here, but I
remember pointing out some issues with one of Google patches recently.
Unfortunately my mailbox receives like 300 mails per day, so this does
not help...

Best regards,
Krzysztof