Re: [PATCH 4/5] ARM: dts: qcom: add pxo/cxo clock-output-names for ipq8064

From: Dmitry Baryshkov
Date: Wed Jul 06 2022 - 04:30:06 EST


On Tue, 5 Jul 2022 at 23:56, Christian Marangi <ansuelsmth@xxxxxxxxx> wrote:
>
> Drivers expect to call pxo/cxo_board clock as pxo/cxo.
> Use clock-output-names to set the correct naming for these fixed clock
> to save drivers that are migrating to parent_data and still use
> parent_names.

Please no. There is no reason to add these names. Let's follow the
example of other platforms.

>
> Signed-off-by: Christian Marangi <ansuelsmth@xxxxxxxxx>
> ---
> arch/arm/boot/dts/qcom-ipq8064.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom-ipq8064.dtsi
> index 1425a4e4283f..720e27e29627 100644
> --- a/arch/arm/boot/dts/qcom-ipq8064.dtsi
> +++ b/arch/arm/boot/dts/qcom-ipq8064.dtsi
> @@ -302,12 +302,14 @@ cxo_board: cxo_board {
> compatible = "fixed-clock";
> #clock-cells = <0>;
> clock-frequency = <25000000>;
> + clock-output-names = "cxo";
> };
>
> pxo_board: pxo_board {
> compatible = "fixed-clock";
> #clock-cells = <0>;
> clock-frequency = <25000000>;
> + clock-output-names = "pxo";
> };
>
> sleep_clk: sleep_clk {
> --
> 2.36.1
>


--
With best wishes
Dmitry