Re: [PATCH v4 2/5] dt-bindings: display: bridge: cdns,dsi: Add compatible for dsi on j721e

[Krzysztof Kozlowski]

On 05/07/2022 14:11, Rahul T R wrote:
> Add compatible to support dsi bridge on j721e
> 
> Signed-off-by: Rahul T R <r-ravikumar@xxxxxx>
> ---
>  .../bindings/display/bridge/cdns,dsi.yaml     | 24 +++++++++++++++++--
>  1 file changed, 22 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/bridge/cdns,dsi.yaml b/Documentation/devicetree/bindings/display/bridge/cdns,dsi.yaml
> index ccedc73d8c18..33a88b39cf09 100644
> --- a/Documentation/devicetree/bindings/display/bridge/cdns,dsi.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/cdns,dsi.yaml
> @@ -14,13 +14,17 @@ description: |
>  
>  properties:
>    compatible:
> -    items:
> -      - const: cdns,dsi
> +    enum:
> +      - cdns,dsi
> +      - ti,j721e-dsi
>  
>    reg:
> +    minItems: 1
>      items:
>        - description:
>            Register block for controller's registers.
> +      - description:
> +          Register block for wrapper settings registers in case of TI J7 SoCs.
>  
>    clocks:
>      items:
> @@ -74,6 +78,22 @@ properties:
>  allOf:
>    - $ref: ../dsi-controller.yaml#
>  
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: ti,j721e-dsi
> +    then:
> +      properties:
> +        reg:
> +          minItems: 2
> +          maxItems: 2
> +    else:
> +      properties:
> +        reg:
> +          minItems: 1

minItems are not needed here.

> +          maxItems: 1
> +
>  required:
>    - compatible
>    - reg


Best regards,
Krzysztof