Re: [PATCH v3] mm, hugetlb: skip irrelevant nodes in show_free_areas()

From: Mike Kravetz
Date: Tue Jul 05 2022 - 18:54:46 EST


On 07/05/22 17:21, Gang Li wrote:
> show_free_areas() allows to filter out node specific data which is
> irrelevant to the allocation request. But hugetlb_show_meminfo() still
> shows hugetlb on all nodes, which is redundant and unnecessary.
>
> Use show_mem_node_skip() to skip irrelevant nodes. And replace
> hugetlb_show_meminfo() with hugetlb_show_meminfo_node(nid).
>
> Signed-off-by: Gang Li <ligang.bdlg@xxxxxxxxxxxxx>
> ---
> v3: move for_each_hstate() into hugetlb_show_meminfo_node().
> v2: replace hugetlb_show_meminfo() with hugetlb_show_meminfo_node(nid) to avoid
> exporting show_mem_node_skip.
> ---
> include/linux/hugetlb.h | 4 ++--
> mm/hugetlb.c | 18 ++++++++----------
> mm/page_alloc.c | 8 ++++++--
> 3 files changed, 16 insertions(+), 14 deletions(-)

Thanks. That should make hugetlb information produced by show_free_areas
consistent with other node specific information.

Reviewed-by: Mike Kravetz <mike.kravetz@xxxxxxxxxx>
--
Mike Kravetz