Re: [RFC PATCH] crypto: flush poison data

From: Christoph Hellwig
Date: Tue Jul 05 2022 - 12:42:26 EST


On Tue, Jul 05, 2022 at 10:21:13AM +0200, LABBE Corentin wrote:
>
> I just copied what did drivers/crypto/xilinx/zynqmp-sha.c.
> I tried to do flush_dcache_range() but it seems to not be implemented on riscV.

That driver is broken and should no have been merged in that form.

> And flush_dcache_page(virt_to_page(addr), len) produce a kernel panic.

And that's good so. Drivers have no business doing their own cache
flushing. That is the job of the dma-mapping implementation, so I'd
suggest to look for problems there.