On Tue, Jul 5, 2022 at 5:11 PM John Garry<john.garry@xxxxxxxxxx> wrote:
On 05/07/2022 12:43, Andy Shevchenko wrote:Not only. In the case of fwnode it's a long story behind its corner
Use dev_fwnode() and acpi_fwnode_handle() instead of dereferencing...which is a better coding practice, right? If so, it would be nice to
an fwnode handle directly.
mention it - well at least I think so.
case(s) where in the future we might switch from embedded structure to
linked list, for example, in order to address those corner cases.
Should I write a paragraph for that as well?
...
Apart from above and nit, below:See below my answer.
Acked-by: John Garry<john.garry@xxxxxxxxxx>Thanks.
...
First of all, even before the 100 characters era the rule had two exceptions:- sys_port = logic_pio_trans_hwaddr(&host->fwnode, res->start, len);nit: currently the driver keeps to the old 80 character line limit.
+ sys_port = logic_pio_trans_hwaddr(acpi_fwnode_handle(host), res->start, len);
While the rules may have been relaxed, I'd rather we still maintain it.
1) the string literals;
2) the readability over strictness of the 80 characters rule.
While I agree in general with you, in this case I think keeping
strictness makes readability worse.