Re: [PATCH v3] hisi_lpc: Use acpi_dev_for_each_child()

From: John Garry
Date: Tue Jul 05 2022 - 11:17:03 EST


Next, I'd look at introducing something like

acpi_create_platform_device_ops(struct acpi_device *adev, const struct
property_entry *properties, const struct *platform_device_create_ops
*ops);

where ops would be a set of callbacks to invoke as a matter of customization.

Then, acpi_create_platform_device() can be defined as a wrapper around
the above.
.

ok, that seems easiest. But alternatively do you see any scope to have that platform_device_create_ops * ops in the acpi_device struct (so that we don't need to create this new API)?

Thanks,
John