Re: [PATCH] sched/fair: fix boolreturn.cocci warning

From: Steven Rostedt
Date: Tue Jul 05 2022 - 10:31:52 EST


On Tue, 5 Jul 2022 15:38:22 +0800
Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx> wrote:

> This was found by coccicheck:
>
> ./kernel/sched/fair.c:9988:9-10: WARNING: return of 0/1 in function 'imbalanced_active_balance' with return type bool.
>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx>

As your subject says "fix boolreturn.cocci warning". Can you please?

That is, this change has been presented 10 times before, and every time
it is nacked or ignored. The true fix is to fix boolreturn.cocci to not
warn about this in existing code.

Just in case it wasn't clear. NACK to this change.

-- Steve