Re: [PATCH] dt-bindings: leds: lp50xx: fix LED children names

From: Krzysztof Kozlowski
Date: Tue Jul 05 2022 - 08:26:05 EST


On 24/06/2022 19:31, Krzysztof Kozlowski wrote:
> On 24/06/2022 19:26, Rob Herring wrote:
>> On Fri, 24 Jun 2022 13:13:25 +0200, Krzysztof Kozlowski wrote:
>>> The lp50xx LEDs expects to have single-color LED children with unit
>>> addresses. This is required by the driver and provided by existing
>>> DTSes. Fix the binding to match actual usage.
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>>> Fixes: dce1452301e7 ("dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers")
>>> ---
>>> Documentation/devicetree/bindings/leds/leds-lp50xx.yaml | 8 +++++++-
>>> 1 file changed, 7 insertions(+), 1 deletion(-)
>>>
>>
>> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
>> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>>
>> yamllint warnings/errors:
>>
>> dtschema/dtc warnings/errors:
>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/leds/leds-lp50xx.example.dtb: led-controller@14: multi-led@2:#size-cells:0:0: 0 was expected
>> From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
>>
>
> This is expected and fixed in:
> https://lore.kernel.org/all/20220607075247.58048-1-krzysztof.kozlowski@xxxxxxxxxx/
>
> I did not combine this patch with above patchset because this one is a
> fix and might be backported to stable.
>

Anyone willing to pick this up? This is a fix.

Best regards,
Krzysztof