Re: [PATCH 16/43] dt-bindings: phy: qcom,qmp-pcie: drop unused vddp-ref-clk supply

[Johan Hovold]

On Tue, Jul 05, 2022 at 12:16:34PM +0200, Krzysztof Kozlowski wrote:
> On 05/07/2022 11:42, Johan Hovold wrote:
> > Only UFS PHY nodes in mainline have a vddp-ref-clk supply. Drop it from
> > the PCIe PHY binding.
> > 
> 
> That's not really good reason. Either the hardware uses ref-clk supply
> or not. Now it looks like you copied everything from common schema and
> clean things up. That's not how it should be organize.

Yes, and I've been pretty clear that that's how I'm going about to
disentangle the current binding.
 
> It's okay to copy existing bindings which are applicable and then in
> separate patch deprecate things or remove pieces which are not correct.
> But all this in assumption that the first copy already selected only
> applicable parts.

But how would you be able to tell what parts I left out from the
original copy unless I first do the split and then explicitly remove
things that were presumably *never* applicable and just happened to be
added because all bindings where combined in one large mess of a schema?

Johan