Re: [PATCH 38/43] phy: qcom-qmp-pcie: drop pipe clock lane suffix

[Dmitry Baryshkov]

On 05/07/2022 13:20, Krzysztof Kozlowski wrote:
> On 05/07/2022 11:42, Johan Hovold wrote:
> > The pipe clock is defined in the "lane" node so there's no need to keep
> > adding a redundant lane-number suffix to the clock name.
> >
> > Drop the lane suffix from the pipe clock name, but continue supporting
> > the legacy name as a fall back.
> >
> > Signed-off-by: Johan Hovold <johan+linaro@xxxxxxxxxx>
> > ---
> >   drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 8 ++++++--
> >   1 file changed, 6 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c
> > index 385ea3d8de08..254ad25591b9 100644
> > --- a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c
> > +++ b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c
> > @@ -2210,8 +2210,12 @@ int qcom_qmp_phy_pcie_create(struct device *dev, struct device_node *np, int id,
> >   	if (!qphy->pcs_misc)
> >   		dev_vdbg(dev, "PHY pcs_misc-reg not used\n");
> >   
> > -	snprintf(prop_name, sizeof(prop_name), "pipe%d", id);
> > -	qphy->pipe_clk = devm_get_clk_from_child(dev, np, prop_name);
> > +	qphy->pipe_clk = devm_get_clk_from_child(dev, np, "pipe");
>
> Just get first clock and no need for handling any deprecation.

If I got it correctly, passing NULL instead of the name would do the trick.

--
With best wishes
Dmitry