Re: [PATCH 40/43] phy: qcom-qmp-combo: drop pipe clock lane suffix

From: Krzysztof Kozlowski
Date: Tue Jul 05 2022 - 06:21:05 EST


On 05/07/2022 11:42, Johan Hovold wrote:
> The pipe clock is defined in the "lane" node so there's no need to keep
> adding a redundant lane-number suffix to the clock name.
>
> Drop the lane suffix from the pipe clock name, but continue supporting
> the legacy name as a fall back.
>
> Signed-off-by: Johan Hovold <johan+linaro@xxxxxxxxxx>
> ---
> drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c
> index b266514ae9ee..7b2eb234cfc2 100644
> --- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c
> +++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c
> @@ -2558,8 +2558,12 @@ int qcom_qmp_phy_combo_create(struct device *dev, struct device_node *np, int id
> * Otherwise, we initialize pipe clock to NULL for
> * all phys that don't need this.
> */
> - snprintf(prop_name, sizeof(prop_name), "pipe%d", id);
> - qphy->pipe_clk = devm_get_clk_from_child(dev, np, prop_name);
> + qphy->pipe_clk = devm_get_clk_from_child(dev, np, "pipe");

Just grab first clock.

Best regards,
Krzysztof