Re: [PATCH] vDPA/ifcvf: remove duplicated assignment to pointer cfg

From: Jason Wang
Date: Mon Jul 04 2022 - 23:15:17 EST


On Tue, Jul 5, 2022 at 3:05 AM Colin Ian King <colin.i.king@xxxxxxxxx> wrote:
>
> The assignment to pointer cfg is duplicated, the second assignment
> is redundant and can be removed.
>
> Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx>

Acked-by: Jason Wang <jasowang@xxxxxxxxxx>

> ---
> drivers/vdpa/ifcvf/ifcvf_base.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/vdpa/ifcvf/ifcvf_base.c b/drivers/vdpa/ifcvf/ifcvf_base.c
> index 48c4dadb0c7c..47b94091733c 100644
> --- a/drivers/vdpa/ifcvf/ifcvf_base.c
> +++ b/drivers/vdpa/ifcvf/ifcvf_base.c
> @@ -29,7 +29,6 @@ u16 ifcvf_set_config_vector(struct ifcvf_hw *hw, int vector)
> {
> struct virtio_pci_common_cfg __iomem *cfg = hw->common_cfg;
>
> - cfg = hw->common_cfg;
> vp_iowrite16(vector, &cfg->msix_config);
>
> return vp_ioread16(&cfg->msix_config);
> --
> 2.35.3
>