Re: [PATCH v12 1/7] dt-bindings: arm: sunxi: Add H616 EMAC compatible

From: Samuel Holland
Date: Mon Jul 04 2022 - 19:53:27 EST


On 7/1/22 6:24 AM, Andre Przywara wrote:
> The Allwinner H616 contains an "EMAC" Ethernet MAC compatible to the A64
> version.
>
> Add it to the list of compatible strings.
>
> Signed-off-by: Andre Przywara <andre.przywara@xxxxxxx>
> ---
> .../devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml b/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml
> index 6a4831fd3616c..87f1306831cc9 100644
> --- a/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml
> +++ b/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml
> @@ -22,6 +22,7 @@ properties:
> - enum:
> - allwinner,sun20i-d1-emac
> - allwinner,sun50i-h6-emac
> + - allwinner,sun50i-h616-emac

The H616 manual has register fields for an internal PHY, like H3. Are these not
hooked up for either EMAC?

Regards,
Samuel

> - const: allwinner,sun50i-a64-emac
>
> reg:
>