Re: [PATCH 1/4] mm/gup: Add FOLL_INTERRUPTIBLE

From: Matthew Wilcox
Date: Mon Jul 04 2022 - 18:48:26 EST


On Wed, Jun 22, 2022 at 05:36:53PM -0400, Peter Xu wrote:
> +/*
> + * GUP always responds to fatal signals. When FOLL_INTERRUPTIBLE is
> + * specified, it'll also respond to generic signals. The caller of GUP
> + * that has FOLL_INTERRUPTIBLE should take care of the GUP interruption.
> + */
> +static bool gup_signal_pending(unsigned int flags)
> +{
> + if (fatal_signal_pending(current))
> + return true;
> +
> + if (!(flags & FOLL_INTERRUPTIBLE))
> + return false;
> +
> + return signal_pending(current);
> +}

This should resemble signal_pending_state() more closely, if indeed not
be a wrapper of signal_pending_state().