Re: [PATCH v3 02/12] thermal/of: Replace device node match with device node search

From: Daniel Lezcano
Date: Mon Jul 04 2022 - 17:18:22 EST


On 04/07/2022 09:59, Lukasz Luba wrote:

[ ... ]

-    for_each_child_of_node(child, gchild) {
+    for_each_child_of_node(trips, gchild) {
          ret = thermal_of_populate_trip(gchild, &tz->trips[i++]);
          if (ret)
              goto free_trips;
      }
-    of_node_put(child);
-

It's probably needed to put the 'trips' here, isn't it?
Or at the end in 'free_trips'.

Right, it is fixed later in another patch but I'll fix it here too.

Thanks for spotting this