Re: [PATCH] pinctrl: qcom-pmic-gpio: Make irqchip immutable

From: kernel test robot
Date: Mon Jul 04 2022 - 16:09:55 EST


Hi Manivannan,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linusw-pinctrl/devel]
[also build test WARNING on linus/master v5.19-rc5 next-20220704]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/intel-lab-lkp/linux/commits/Manivannan-Sadhasivam/pinctrl-qcom-pmic-gpio-Make-irqchip-immutable/20220704-230712
base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel
config: arm-defconfig (https://download.01.org/0day-ci/archive/20220705/202207050342.WcNFJKKy-lkp@xxxxxxxxx/config)
compiler: arm-linux-gnueabi-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/4de81cf5dd3098fa10c3e384d497e024675cf068
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Manivannan-Sadhasivam/pinctrl-qcom-pmic-gpio-Make-irqchip-immutable/20220704-230712
git checkout 4de81cf5dd3098fa10c3e384d497e024675cf068
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/pinctrl/qcom/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

>> drivers/pinctrl/qcom/pinctrl-spmi-gpio.c:998:37: warning: excess elements in struct initializer
998 | .flags = IRQCHIP_IMMUTABLE, IRQCHIP_MASK_ON_SUSPEND,
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/pinctrl/qcom/pinctrl-spmi-gpio.c:998:37: note: (near initialization for 'pmic_gpio_irqchip')


vim +998 drivers/pinctrl/qcom/pinctrl-spmi-gpio.c

990
991 static const struct irq_chip pmic_gpio_irqchip = {
992 .name = "spmi-gpio",
993 .irq_ack = irq_chip_ack_parent,
994 .irq_mask = irq_chip_mask_parent,
995 .irq_unmask = irq_chip_unmask_parent,
996 .irq_set_type = irq_chip_set_type_parent,
997 .irq_set_wake = irq_chip_set_wake_parent,
> 998 .flags = IRQCHIP_IMMUTABLE, IRQCHIP_MASK_ON_SUSPEND,
999 GPIOCHIP_IRQ_RESOURCE_HELPERS,
1000 };
1001

--
0-DAY CI Kernel Test Service
https://01.org/lkp