Re: [PATCH] ACPICA: Use swap() instead of open coding it

[Rafael J. Wysocki]

On 7/4/2022 4:06 PM, Tan Zhongjun wrote:
> Use swap() instead of open coding it
>
> Signed-off-by: Tan Zhongjun <tanzhongjun@xxxxxxxxxxx>

Changes in the ACPICA files need to be routed through the upstream 
ACPICA project at github.

Please submit a pull request in there.


> ---
>   drivers/acpi/acpica/nsrepair2.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/acpi/acpica/nsrepair2.c b/drivers/acpi/acpica/nsrepair2.c
> index dd533c887e3a..3735ba06ea16 100644
> --- a/drivers/acpi/acpica/nsrepair2.c
> +++ b/drivers/acpi/acpica/nsrepair2.c
> @@ -875,7 +875,6 @@ acpi_ns_sort_list(union acpi_operand_object **elements,
>   {
>   	union acpi_operand_object *obj_desc1;
>   	union acpi_operand_object *obj_desc2;
> -	union acpi_operand_object *temp_obj;
>   	u32 i;
>   	u32 j;
>   
> @@ -892,9 +891,7 @@ acpi_ns_sort_list(union acpi_operand_object **elements,
>   			    || ((sort_direction == ACPI_SORT_DESCENDING)
>   				&& (obj_desc1->integer.value <
>   				    obj_desc2->integer.value))) {
> -				temp_obj = elements[j - 1];
> -				elements[j - 1] = elements[j];
> -				elements[j] = temp_obj;
> +				swap(elements[j - 1], elements[j]);
>   			}
>   		}
>   	}