Re: [PATCH v8 2/4] soc: qcom: icc-bwmon: Add bandwidth monitoring driver

[Randy Dunlap]

On 7/4/22 08:22, Krzysztof Kozlowski wrote:
> On 04/07/2022 17:20, Randy Dunlap wrote:
>> Hi,
>>
>> On 7/4/22 05:17, Krzysztof Kozlowski wrote:
>>> diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
>>> index e718b8735444..2c8091535bf7 100644
>>> --- a/drivers/soc/qcom/Kconfig
>>> +++ b/drivers/soc/qcom/Kconfig
>>> @@ -228,4 +228,19 @@ config QCOM_APR
>>>  	  application processor and QDSP6. APR is
>>>  	  used by audio driver to configure QDSP6
>>>  	  ASM, ADM and AFE modules.
>>> +
>>> +config QCOM_ICC_BWMON
>>> +	tristate "QCOM Interconnect Bandwidth Monitor driver"
>>> +	depends on ARCH_QCOM || COMPILE_TEST
>>> +	select PM_OPP
>>> +	help
>>> +	  Sets up driver monitoring bandwidth on various interconnects and
>>
>> 	  Sets up driver bandwidth monitoring
>>
>> would be better, I think.
> 
> It's a driver which monitors bandwidth, so your version sounds a bit
> like monitoring of driver's bandwidth.
> 
> Maybe should be:
>     Sets up driver which monitors bandwidth...
> ?

Yes, that's OK.
Thanks.

-- 
~Randy