Re: [PATCH] PCI: iproc: Use the bitmap API to allocate bitmaps

From: Ray Jui
Date: Mon Jul 04 2022 - 13:28:20 EST




On 7/4/2022 6:15 AM, Christophe JAILLET wrote:
> Use bitmap_zalloc()/bitmap_free() instead of hand-writing them.
>
> It is less verbose and it improves the semantic.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> ---
> drivers/pci/controller/pcie-iproc-msi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/controller/pcie-iproc-msi.c b/drivers/pci/controller/pcie-iproc-msi.c
> index 757b7fbcdc59..fee036b07cd4 100644
> --- a/drivers/pci/controller/pcie-iproc-msi.c
> +++ b/drivers/pci/controller/pcie-iproc-msi.c
> @@ -589,8 +589,8 @@ int iproc_msi_init(struct iproc_pcie *pcie, struct device_node *node)
> msi->has_inten_reg = true;
>
> msi->nr_msi_vecs = msi->nr_irqs * EQ_LEN;
> - msi->bitmap = devm_kcalloc(pcie->dev, BITS_TO_LONGS(msi->nr_msi_vecs),
> - sizeof(*msi->bitmap), GFP_KERNEL);
> + msi->bitmap = devm_bitmap_zalloc(pcie->dev, msi->nr_msi_vecs,
> + GFP_KERNEL);
> if (!msi->bitmap)
> return -ENOMEM;
>

Improvement looks fine to me. Thanks.

Acked-by: Ray Jui <ray.jui@xxxxxxxxxxxx>

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature