Re: [PATCH v8 2/4] soc: qcom: icc-bwmon: Add bandwidth monitoring driver

[Randy Dunlap]

Hi,

On 7/4/22 05:17, Krzysztof Kozlowski wrote:
> diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
> index e718b8735444..2c8091535bf7 100644
> --- a/drivers/soc/qcom/Kconfig
> +++ b/drivers/soc/qcom/Kconfig
> @@ -228,4 +228,19 @@ config QCOM_APR
>  	  application processor and QDSP6. APR is
>  	  used by audio driver to configure QDSP6
>  	  ASM, ADM and AFE modules.
> +
> +config QCOM_ICC_BWMON
> +	tristate "QCOM Interconnect Bandwidth Monitor driver"
> +	depends on ARCH_QCOM || COMPILE_TEST
> +	select PM_OPP
> +	help
> +	  Sets up driver monitoring bandwidth on various interconnects and

	  Sets up driver bandwidth monitoring

would be better, I think.

> +	  based on that voting for interconnect bandwidth, adjusting their
> +	  speed to current demand.
> +	  Current implementation brings support for BWMON v4, used for example
> +	  on SDM845 to measure bandwidth between CPU (gladiator_noc) and Last
> +	  Level Cache (memnoc).  Usage of this BWMON allows to remove some of
> +	  the fixed bandwidth votes from cpufreq (CPU nodes) thus achieve high
> +	  memory throughput even with lower CPU frequencies.

-- 
~Randy