[PATCH v3 16/16] mm/huge_memory: use helper macro IS_ERR_OR_NULL in split_huge_pages_pid

From: Miaohe Lin
Date: Mon Jul 04 2022 - 09:24:24 EST


Use helper macro IS_ERR_OR_NULL to check the validity of page to simplify
the code. Minor readability improvement.

Signed-off-by: Miaohe Lin <linmiaohe@xxxxxxxxxx>
Reviewed-by: Muchun Song <songmuchun@xxxxxxxxxxxxx>
---
mm/huge_memory.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/mm/huge_memory.c b/mm/huge_memory.c
index 8380912b39fd..fd9d502aadc4 100644
--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c
@@ -3062,9 +3062,7 @@ static int split_huge_pages_pid(int pid, unsigned long vaddr_start,
/* FOLL_DUMP to ignore special (like zero) pages */
page = follow_page(vma, addr, FOLL_GET | FOLL_DUMP);

- if (IS_ERR(page))
- continue;
- if (!page || is_zone_device_page(page))
+ if (IS_ERR_OR_NULL(page) || is_zone_device_page(page))
continue;

if (!is_transparent_hugepage(page))
--
2.23.0