[PATCH] peci: fix potential memory leak in devm_adev_add()
From: Jianglei Nie
Date: Mon Jul 04 2022 - 09:00:07 EST
devm_adev_add() allocates a memory chunk for "adev" and "adev->name"
with adev_alloc(). When auxiliary_device_add() fails, the function calls
auxiliary_device_uninit(), which doesn't release the allocated "adev"
and "adev->name", thus leading to a memory leak bug.
We should call adev_release() instead of auxiliary_device_uninit() to
release the "adev" and "adev->name".
Signed-off-by: Jianglei Nie <niejianglei2021@xxxxxxx>
---
drivers/peci/cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/peci/cpu.c b/drivers/peci/cpu.c
index 68eb61c65d34..de865997ccde 100644
--- a/drivers/peci/cpu.c
+++ b/drivers/peci/cpu.c
@@ -248,7 +248,7 @@ static int devm_adev_add(struct device *dev, int idx)
ret = auxiliary_device_add(adev);
if (ret) {
- auxiliary_device_uninit(adev);
+ adev_release(&adev->dev);
return ret;
}
--
2.25.1