[PATCH net-next] net/sched: remove return value of unregister_tcf_proto_ops

From: Zhengchao Shao
Date: Mon Jul 04 2022 - 08:38:39 EST


Return value of unregister_tcf_proto_ops is useless, remove it.

Signed-off-by: Zhengchao Shao <shaozhengchao@xxxxxxxxxx>
---
include/net/pkt_cls.h | 2 +-
net/sched/cls_api.c | 6 ++----
2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/include/net/pkt_cls.h b/include/net/pkt_cls.h
index 8cf001aed858..d9d90e6925e1 100644
--- a/include/net/pkt_cls.h
+++ b/include/net/pkt_cls.h
@@ -23,7 +23,7 @@ struct tcf_walker {
};

int register_tcf_proto_ops(struct tcf_proto_ops *ops);
-int unregister_tcf_proto_ops(struct tcf_proto_ops *ops);
+void unregister_tcf_proto_ops(struct tcf_proto_ops *ops);

struct tcf_block_ext_info {
enum flow_block_binder_type binder_type;
diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c
index 9bb4d3dcc994..fdc9acbd56df 100644
--- a/net/sched/cls_api.c
+++ b/net/sched/cls_api.c
@@ -194,10 +194,9 @@ EXPORT_SYMBOL(register_tcf_proto_ops);

static struct workqueue_struct *tc_filter_wq;

-int unregister_tcf_proto_ops(struct tcf_proto_ops *ops)
+void unregister_tcf_proto_ops(struct tcf_proto_ops *ops)
{
struct tcf_proto_ops *t;
- int rc = -ENOENT;

/* Wait for outstanding call_rcu()s, if any, from a
* tcf_proto_ops's destroy() handler.
@@ -209,12 +208,11 @@ int unregister_tcf_proto_ops(struct tcf_proto_ops *ops)
list_for_each_entry(t, &tcf_proto_base, head) {
if (t == ops) {
list_del(&t->head);
- rc = 0;
break;
}
}
write_unlock(&cls_mod_lock);
- return rc;
+ return;
}
EXPORT_SYMBOL(unregister_tcf_proto_ops);

--
2.17.1