Re: [PATCH v2 2/4] mfd: rt5120: Add Richtek PMIC support

[Lee Jones]

On Mon, 04 Jul 2022, ChiYuan Huang wrote:

> Hi, Lee:
> 
> ChiYuan Huang <u0084500@xxxxxxxxx> 於 2022年7月1日 週五 下午5:56寫道：
> >
> > Lee Jones <lee.jones@xxxxxxxxxx> 於 2022年7月1日 週五 下午3:38寫道：
> > >
> > > On Fri, 01 Jul 2022, ChiYuan Huang wrote:
> > >
> > > > HI, Lee:
> > > >
> > > > ChiYuan Huang <u0084500@xxxxxxxxx> 於 2022年6月27日 週一 晚上10:56寫道：
> > > > >
> > > > > Lee Jones <lee.jones@xxxxxxxxxx> 於 2022年6月27日 週一 晚上10:22寫道：
> > > > > >
> > > > > > On Wed, 22 Jun 2022, cy_huang wrote:
> > > > > >
> > > > > > > From: ChiYuan Huang <cy_huang@xxxxxxxxxxx>
> > > > > > >
> > > > > > > Add Richtek RT5120 PMIC I2C driver.
> > > > > >
> > > > > > Why a whole new driver?
> > > > > >
> > > > > > How different is this to rt5033?
> > > > > >
> > > > > > Looks like this could easily be woven into this existing support?
> > > > > >
> > > > > It's different with the function domain.
> > > > > RT5033 is most like as the SubPMIC that includes PMU (battery
> > > > > charger/gauge/led/few buck and ldo)
> > > > > RT5120 is a main PMIC with default-on power that follows the boot on sequence.
> > > > > RT5120 only integrates regulator and power key report module.
> > > > >
> > > > Since I have explained the chip difference, do you still think it's
> > > > better to merge this code into rt5033 mfd?
> > >
> > > I think it's okay to group devices which are similar but not exactly
> > > the same, if they can be.  The integration of this device into the
> > > other looks trivial to my naive eyes.
> > >
> > > A PMIC is a PMIC, main or sub.
> > >
> > M.. ok. I will try to group all chip changes like as devices
> > list/regmap_irq/regmap_config ..., etc.
> > Treat it as one set of chip config and use 'of_device_get_match_data'
> > to get the chip config data.
> >
> There's a question.
> As I know, it's not the same chip series.
> The rt5033 is submitted from Samsung at 2015.
> The driver data is also defined in header file.
> 
> Do you still suggest to do the merge?
> Even in our internal, it's difficult to find a rt5033 EVB for testing.
> 
> And one more question is the binding. If yes, for the binding, I need to add
> rt5033 related.....
> 
> Actually, it's a tough work.

If it's genuinely difficult to integrate, you can keep them separate.

-- 
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog