Re: [PATCH 01/11] dt-bindings: arm: mediatek: Add MT8195 Cherry Tomato Chromebooks
From: AngeloGioacchino Del Regno
Date: Mon Jul 04 2022 - 04:51:35 EST
Il 01/07/22 17:31, Nícolas F. R. A. Prado ha scritto:
On Thu, Jun 30, 2022 at 05:33:06PM +0200, AngeloGioacchino Del Regno wrote:
Document board compatibles for the MT8195 Cherry platform's
Tomato Chromebooks, at the time of writing composed of four
revisions (r0, r1, r2, r3-r4).
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
---
Documentation/devicetree/bindings/arm/mediatek.yaml | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
index dd6c6e8011f9..3e0afa17ed2e 100644
--- a/Documentation/devicetree/bindings/arm/mediatek.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
@@ -144,6 +144,19 @@ properties:
- const: google,spherion-rev0
- const: google,spherion
- const: mediatek,mt8192
+ - description: Google Tomato (Acer Chromebook Spin 513)
Hi Angelo,
searching for "Acer Chromebook Spin 513" I found that there are two different
chromebooks:
https://www.acer.com/ac/en/US/content/series/acerchromebookspin513
https://www.acer.com/ac/en/GB/content/series/acerchromebookspin513cp5132h
The first one is a Qualcomm based one, while the second is mt8195-based, so I
assume that's Tomato.
They can be telled apart by the model name though: the Qualcomm one is
"CP513-1H", while Tomato is "CP513-2H". So I suggest to add the "CP513-2H" here
in the description, as well as in the cover letter, to avoid confusion between
the two.
Hey Nicolas,
nice catch!
Even though it would be odd for someone to think that we refer to a Qualcomm
powered Chromebook while checking 'mediatek.yaml'... I agree with you, let's
specify the model clearly as 'CP513-2H': it fits, so why not!
I'll send a v2 soon.
Cheers!
Thanks,
Nícolas