Re: [PATCH 2/3] arm64: dts: imx8ulp: Add the fec support

From: Andrew Lunn
Date: Mon Jul 04 2022 - 04:14:01 EST


> > + clocks = <&cgc1 IMX8ULP_CLK_XBAR_DIVBUS>,
> > + <&pcc4 IMX8ULP_CLK_ENET>,
> > + <&cgc1 IMX8ULP_CLK_ENET_TS_SEL>,
> > + <&clock_ext_rmii>;
> > + clock-names = "ipg", "ahb", "ptp", "enet_clk_ref";
>
> I think the default should be the other way round, assume MAC to provide reference
> clock and allow override on board-level if PHY does it instead.

I would make it the same as all the other instances of FEC in the
IMX7, IMX6, IMX5, IMX4, Vybrid etc

Andrew