RE: [PATCH V4 3/7] clk: export of_clk_bulk_get_all

[Peng Fan (OSS)]

Hi Stephen,

> Subject: RE: [PATCH V4 3/7] clk: export of_clk_bulk_get_all
[Peng Fan] 

I am going to make a new version of this patchset. Please kindly
a Yes or No with this patch.

Thanks,
Peng.

> 
> Stephen,
> 
> > Subject: [PATCH V4 3/7] clk: export of_clk_bulk_get_all
> 
> Are you fine with this patch?
> Patch 4 "soc: imx: add i.MX93 SRC power domain driver"
> depends on this patch, if you are not happy with patch 3, I still have time to
> rework patch 4.
> 
> Thanks,
> Peng.
> 
> >
> > From: Peng Fan <peng.fan@xxxxxxx>
> >
> > Export of_clk_bulk_get_all, so drivers could use this API.
> >
> > Signed-off-by: Peng Fan <peng.fan@xxxxxxx>
> > ---
> >  drivers/clk/clk-bulk.c | 3 ++-
> >  include/linux/clk.h    | 2 ++
> >  2 files changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/clk/clk-bulk.c b/drivers/clk/clk-bulk.c index
> > e9e16425c739..470155856b02 100644
> > --- a/drivers/clk/clk-bulk.c
> > +++ b/drivers/clk/clk-bulk.c
> > @@ -43,7 +43,7 @@ static int __must_check of_clk_bulk_get(struct
> > device_node *np, int num_clks,
> >  	return ret;
> >  }
> >
> > -static int __must_check of_clk_bulk_get_all(struct device_node *np,
> > +int __must_check of_clk_bulk_get_all(struct device_node *np,
> >  					    struct clk_bulk_data **clks)  {
> >  	struct clk_bulk_data *clk_bulk;
> > @@ -68,6 +68,7 @@ static int __must_check of_clk_bulk_get_all(struct
> > device_node *np,
> >
> >  	return num_clks;
> >  }
> > +EXPORT_SYMBOL_GPL(of_clk_bulk_get_all);
> >
> >  void clk_bulk_put(int num_clks, struct clk_bulk_data *clks)  { diff
> > --git a/include/linux/clk.h b/include/linux/clk.h index
> > 39faa54efe88..ca74f4e83d25
> > 100644
> > --- a/include/linux/clk.h
> > +++ b/include/linux/clk.h
> > @@ -372,6 +372,8 @@ int __must_check clk_bulk_get(struct device *dev,
> > int num_clks,  int __must_check clk_bulk_get_all(struct device *dev,
> >  				  struct clk_bulk_data **clks);
> >
> > +int __must_check of_clk_bulk_get_all(struct device_node *np,
> > +				     struct clk_bulk_data **clks);
> >  /**
> >   * clk_bulk_get_optional - lookup and obtain a number of references
> > to clock producer
> >   * @dev: device for clock "consumer"
> > --
> > 2.25.1