Re: [PATCH v5 11/15] spi: cadence-quadspi: Add compatible for AMD Pensando Elba SoC

From: Brad Larson
Date: Sun Jul 03 2022 - 17:09:24 EST


Hi Mark,

On Tue, Jun 14, 2022 at 5:01 AM Mark Brown <broonie@xxxxxxxxxx> wrote:
>
> On Mon, Jun 13, 2022 at 12:56:54PM -0700, Brad Larson wrote:
>
> > + /*
> > + * If a hazard exists between the APB and AHB interfaces, perform a
> > + * dummy readback from the controller to ensure synchronization.
> > + */
> > + if (cqspi->apb_ahb_hazard)
> > + (void)readl(reg_base + CQSPI_REG_INDIRECTWR);
>
> You shouldn't need the cast here.

Removed (void) cast

Regards,
Brad