Re: [perf-tools] Build-error in tools/perf/util/annotate.c with LLVM-14

From: Sedat Dilek
Date: Sun Jul 03 2022 - 16:33:10 EST


On Sun, Jul 3, 2022 at 7:47 PM Arnaldo Carvalho de Melo
<arnaldo.melo@xxxxxxxxx> wrote:
>
>
>
> On July 3, 2022 1:54:48 PM GMT-03:00, Andres Freund <andres@xxxxxxxxxxx> wrote:
> >Hi,
> >
> >On 2022-07-03 10:54:45 -0300, Arnaldo Carvalho de Melo wrote:
> >> That series should be split a bit further, so that the
> >> new features test is in a separate patch, i.e. I don't process bpftool patches, but can process the feature test and the tools/perf part.
> >
> >Ok, will split it further. Should I do
> >
> >1) feature test
> >2) introduce compat header header
> >3) use feature test, use header in perf/
> >4) use feature test, use header in bpf/
> >
> >Or should 3, 4 be split to separately introduce the feature test and use of
> >the compat header?
>
> I think 4 patches are ok,
>

Andres can you CC me on a new patchset?
Thanks.

-sed@-