Re: [PATCH] dt-bindings: soc: samsung: s5pv210-chipid: add S5PV210 ChipID

From: Krzysztof Kozlowski
Date: Sun Jul 03 2022 - 14:15:43 EST


On 01/07/2022 19:35, Rob Herring wrote:
> On Wed, Jun 29, 2022 at 02:35:43PM +0200, Krzysztof Kozlowski wrote:
>> Add bindings for the S5PV210 ChipID block.
>
> Is this new or was undocumented?

Undocumented, I'll mention in the commit msg.

>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>> ---
>> .../bindings/soc/samsung/s5pv210-chipid.yaml | 30 +++++++++++++++++++
>
> samsung,s5pv210-chipid.yaml

Hm, even for files under "samsung" directory?

>
> Surely there's other similar blocks. Can we start collecting in a
> common directory?

It's a soc-specific driver, type of soc_device. If you think it's worth
a place of its own, I can put it somewhere dedicated.

Best regards,
Krzysztof