Re: [PATCH v11 09/14] module: Move kallsyms support into a separate file

[Aaron Tomlin]

On Sun 2022-07-03 09:23 -0400, Steven Rostedt wrote:
> BTW, *NEVER* modify code that you are moving. Really, *NEVER* do that!
> 
> It makes debugging much more difficult, like in this very case.
> 
> *ALWAYS* have the moving of code be a separate patch. Keep as most
> identical as humanly possible. Even keep white space errors the same!
> You can add a clean up patch before or after the move. But never do it
> as one patch!

Hi Steve,

I completely agree and noted.

> You even stated "no functional change" which was a lie. Converting
> strlcpy() to strscpy() *is* a functional change!

Understood.


Kind regards,

-- 
Aaron Tomlin