Re: [PATCH 3/8] lib/bitmap: change type of bitmap_weight to unsigned int

From: Andy Shevchenko
Date: Sat Jul 02 2022 - 07:58:16 EST


On Fri, Jul 01, 2022 at 05:54:25AM -0700, Yury Norov wrote:
> bitmap_weight() doesn't return negative values, so change it's type
> to unsigned int.

Patch (the code) suggests something else.

> It may help compiler to generate better code and
> catch bugs.

...

> -int __bitmap_weight(const unsigned long *bitmap, unsigned int nbits);
> +unsigned long __bitmap_weight(const unsigned long *bitmap, unsigned int nbits);

--
With Best Regards,
Andy Shevchenko