Re: [PATCH v3 0/9] drm: selftest: Convert to KUnit

From: Javier Martinez Canillas
Date: Sat Jul 02 2022 - 07:56:37 EST


On 6/30/22 02:46, Maíra Canal wrote:
> Hi everyone,
>
> Here is the v3 of the conversion of selftests to KUnit. Since the v2, there
> have been minor fixes. drm_format_test received the biggest change: the
> KUNIT_EXPECT_FALSE and KUNIT_EXPECT_TRUE macros were changed to KUNIT_EXPECT_EQ,
> as suggested by Daniel.
>
> Most of all, the patches were rebased on top of the recently applied patches
> for drm_format_helper tests (8f456104915f), in order to avoid conflicts when
> applying the tests.
>
> Thanks for your attention and any feedback is welcomed!
>
> Best Regards,
> - Maíra Canal
>

Thanks a lot for working on this! The patches look good to me, I just had some
minor comments. If you re-spin, I think that we can just push the whole series
to drm-misc since the patches have been in the mailing list for some time and
have already been tested/reviewed.

--
Best regards,

Javier Martinez Canillas
Linux Engineering
Red Hat