Re: [PATCH v3 2/6] Staging: rtl8192e: Avoid multiple assignments

From: Philipp Hortmann
Date: Sat Jul 02 2022 - 02:08:33 EST


On 7/1/22 11:24, Felix Schlepper wrote:
This addresses an issue raised by checkpatch.pl:

$ ./scripts/checkpatch.pl --terse -f drivers/staging/rtl8192e/rtllib_wx.c
CHECK: multiple assignments should be avoided

Signed-off-by: Felix Schlepper <f3sch.git@xxxxxxxxxxx>
---
drivers/staging/rtl8192e/rtllib_wx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8192e/rtllib_wx.c b/drivers/staging/rtl8192e/rtllib_wx.c
index b7f19b38b0e1..121bf939c6a4 100644
--- a/drivers/staging/rtl8192e/rtllib_wx.c
+++ b/drivers/staging/rtl8192e/rtllib_wx.c
@@ -149,7 +149,8 @@ static inline char *rtl819x_translate_scan(struct rtllib_device *ieee,
max_rate = rate;
}
iwe.cmd = SIOCGIWRATE;
- iwe.u.bitrate.fixed = iwe.u.bitrate.disabled = 0;
+ iwe.u.bitrate.disabled = 0;
+ iwe.u.bitrate.fixed = 0;
iwe.u.bitrate.value = max_rate * 500000;
start = iwe_stream_add_event_rsl(info, start, stop, &iwe, IW_EV_PARAM_LEN);
iwe.cmd = IWEVCUSTOM;


Tested-by: Philipp Hortmann <philipp.g.hortmann@xxxxxxxxx>